Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pytest-factoryboy: init at 2.0.3 #89248

Merged
merged 1 commit into from Jun 2, 2020
Merged

pytest-factoryboy: init at 2.0.3 #89248

merged 1 commit into from Jun 2, 2020

Conversation

winpat
Copy link
Member

@winpat winpat commented May 31, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@winpat winpat marked this pull request as ready for review May 31, 2020 14:28
drewrisinger
drewrisinger suggested changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission, but it looks like this needs a little bit more formatting work. See comments. I didn't test this yet.
Also, for OfBorg to build this properly, the PR title and commits should be changed to python27Packages.pytest-factoryboy: ....
@GrahamcOfBorg build python27Packages.pytest-factoryboy python37Packages.pytest-factoryboy python38Packages.pytest-factoryboy

pkgs/development/python-modules/pytest-factoryboy/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pytest-factoryboy/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pytest-factoryboy/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pytest-factoryboy/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/pytest-factoryboy/default.nix Outdated Show resolved Hide resolved
@drewrisinger
Copy link
Contributor

@GrahamcOfBorg build python27Packages.pytest-factoryboy python37Packages.pytest-factoryboy python38Packages.pytest-factoryboy

@drewrisinger drewrisinger mentioned this pull request Jun 1, 2020
Closed
@winpat winpat force-pushed the add_pytest_factoryboy branch 2 times, most recently from 3d1f19c to ff6bb26 Compare June 2, 2020 10:27
@winpat
Copy link
Member Author

winpat commented Jun 2, 2020

@drewrisinger Thank you for your feedback. I always learn something new when contributing a new package.

drewrisinger
drewrisinger approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM.
Builds fine with nix-review. Haven't tested beyond that, couldn't figure out how to get it opening properly in the shell.

pkgs/development/python-modules/pytest-factoryboy/default.nix Show resolved Hide resolved
jonringer
jonringer approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 89248 1

3 packages built:
- python27Packages.pytest-factoryboy
- python37Packages.pytest-factoryboy
- python38Packages.pytest-factoryboy

@jonringer jonringer merged commit 259f344 into NixOS:master Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@drewrisinger drewrisinger drewrisinger approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@winpat @drewrisinger @jonringer