hdl.rec: don't save casted shapes in Layout constructor #394
+59
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #394 +/- ##
=======================================
Coverage 82.10% 82.10%
=======================================
Files 36 36
Lines 6075 6075
Branches 1234 1234
=======================================
Hits 4988 4988
+ Misses 914 913 -1
- Partials 173 174 +1
Continue to review full report at Codecov.
|
|
Looks like I missed some tests, let me fix those up |
shawnanastasio
force-pushed
the
layout_shape_fix
branch
from
a3bdaa4 to
f432fe4
Compare
whitequark
reviewed
May 31, 2020
| @@ -12,6 +12,11 @@ class UnsignedEnum(Enum): | |||
|
|
|||
|
|
|||
| class LayoutTestCase(FHDLTestCase): | |||
| def compare_field(self, field, expected): | |||
There was a problem hiding this comment.
Suggested change
| def compare_field(self, field, expected): | |
| def assertFieldEqual(self, field, expected): |
whitequark
reviewed
May 31, 2020
shawnanastasio
force-pushed
the
layout_shape_fix
branch
from
f432fe4 to
7243fe2
Compare
|
Updated to address review comments |
|
Could you add a test that checks for the bug you're fixing here, i.e. the Enum decoder functionality? |
shawnanastasio
force-pushed
the
layout_shape_fix
branch
from
421b70a to
7d7833e
Compare
|
Added a test for the enum decoder in |
Don't save the result of Shape.cast in the Layout constructor. This allows the original user-provided shape to be preserved, while still checking its validity. This fixes Enum decoder inference for Signals (amaranth-lang#393).
shawnanastasio
force-pushed
the
layout_shape_fix
branch
from
7d7833e to
72a80fc
Compare
|
Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't save the result of Shape.cast in the Layout constructor.
This allows the original user-provided shape to be preserved,
while still checking its validity.
This fixes Enum decoder inference for Signals (#393).