Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitlab: 12.10.8 -> 13.0.3 #89239

Closed
wants to merge 1 commit into from
Closed

gitlab: 12.10.8 -> 13.0.3 #89239

wants to merge 1 commit into from

Conversation

globin
Copy link
Member

@globin globin commented May 31, 2020

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @petabyteboy @flokli

@globin
Copy link
Member Author

globin commented May 31, 2020

@GrahamcOfBorg test gitlab

@ofborg ofborg bot requested review from fpletz and talyz May 31, 2020 05:37
talyz
talyz requested changes May 31, 2020
View reviewed changes
Copy link
Contributor

@talyz talyz left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I've done a few manual tests and it seems to work well.

Maybe you could add some comments on the changes that aren't just straight up version upgrades? Like the gitaly gitlab-shell config moving into gitaly.toml with a link to https://gitlab.com/gitlab-org/gitaly/-/issues/2182. Also, did you make changes to the upgrade.py script without commiting them or does it just work now?

@globin
Copy link
Member Author

globin commented May 31, 2020

The update script took ages but seems to work.

I just checked how the variables are passed in the gitaly code, didn't see the issue.

@talyz
Copy link
Contributor

talyz commented May 31, 2020

Okay, interesting.

Ah, I see. Well, it's good to document it for future reference anyway, so I would still suggest adding the link or your own observation. :)

@talyz talyz requested review from flokli and a user June 3, 2020 19:46
@talyz
Copy link
Contributor

talyz commented Jun 3, 2020

13.0.4 is out. Can you bump this? :)

@flokli
Copy link
Contributor

flokli commented Jun 3, 2020

@globin can you address the changes?

I realized there's another security update, 12.10.9, for which I opened #89435, so this might need a rebase afterwards.

@globin
Copy link
Member Author

globin commented Jun 4, 2020

very short on time right now, feel free to take over, also ping @WilliButz, @lheckemann

@talyz
Copy link
Contributor

talyz commented Jun 4, 2020

@globin No worries, I'll give it a go today.

@talyz talyz mentioned this pull request Jun 4, 2020
Merged
10 tasks
@talyz
Copy link
Contributor

talyz commented Jun 4, 2020

I couldn't push any changes to this PR, so I opened a new one (#89480).

@flokli
Copy link
Contributor

flokli commented Jun 4, 2020

Let's close this one then.

@flokli flokli closed this Jun 4, 2020
@globin globin deleted the gitlab-13 branch June 5, 2020 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talyz talyz talyz requested changes

@fpletz fpletz Awaiting requested review from fpletz

@flokli flokli Awaiting requested review from flokli

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@globin @talyz @flokli