Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add another missing #include #3704

Merged
merged 1 commit into from Jun 16, 2020
Merged

Conversation

Ericson2314
Copy link
Member

Waiting for CI to make sure I catch everything.

@edolstra
Copy link
Member

Note that the Hydra coverage job builds with precompiled headers disabled, so it should catch this.

@Ericson2314 Ericson2314 changed the title WIP: Add another missing #include Add another missing #include Jun 16, 2020
@Ericson2314
Copy link
Member Author

Ericson2314 commented Jun 16, 2020

I think the GitHub CI does too, in which case the issue must be something like master changing from when the CI was run. Nevermind! Would you be opposed to making PR CI do so? I would prefer catching this earlier than later, especially because when I merge master into my branches our own CI does build coverage and so will fail.

@Ericson2314
Copy link
Member Author

I removed the WIP from this in any case, now that I verified the coverage job myself.

@edolstra
Copy link
Member

Maybe it would be better to just disable precompiled headers in the regular job. Running coverage just for that would be a bit expensive.

@edolstra edolstra merged commit 2cb59f4 into NixOS:master Jun 16, 2020
@Ericson2314
Copy link
Member Author

I'll look into that, then.

@Ericson2314 Ericson2314 deleted the fix-include branch June 16, 2020 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants