Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vlc: 3.0.10 -> 3.0.11 #90642

Merged
merged 1 commit into from Jun 17, 2020
Merged

vlc: 3.0.10 -> 3.0.11 #90642

merged 1 commit into from Jun 17, 2020

Conversation

progval
Copy link
Member

@progval progval commented Jun 16, 2020 •
edited

Release notes: http://git.videolan.org/?p=vlc/vlc-3.0.git;a=tag;h=1519d3219a8d151bca792f40003051fa8b967734

Motivation for this change

Includes a security fix for CVE-2020-13428.
Also available at: http://git.videolan.org/?p=vlc/vlc-3.0.git;a=blobdiff;f=modules/packetizer/hxxx_nal.c;h=6bdfd5a2a58ab9397d5758726ef16dfb27fec2a0;hp=73450606e382329a301e04d37c5ac259951448e8;hb=d5c43c21c747ff30ed19fcca745dea3481c733e0;hpb=441907f4352107737523bf9cfb56eabe3563edb4

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after): no change in dependencies
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@evils
Copy link
Member

evils commented Jun 16, 2020

nixpkgs-review

2 packages failed to build:
- obs-ndi
- tribler
15 packages built:
- elisa
- libsForQt5.phonon-backend-vlc
- libsForQt5.vlc
- megaglest
- minitube
- netease-cloud-music
- obs-linuxbrowser
- obs-studio
- obs-v4l2sink
- obs-wlrobs
- pympress
- python27Packages.python-vlc
- python37Packages.python-vlc
- python38Packages.python-vlc
- strawberry
the failed builds fail to build on current master anyway

closure size goes from 647271688 to 647297448

what's up with the backslashes in the links?

@progval
Copy link
Member Author

progval commented Jun 16, 2020 •
edited

2 packages failed to build:

  • obs-ndi
  • tribler

They both fail to be for me too, but for unrelated failures in their dependencies (which also happen on master). For obs-ndi, it's InstallNDISDK_v4_Linux which requires some manual install:

building '/nix/store/k8vnh3q05vkjghmb1jxx57v36c9qsw40-InstallNDISDK_v4_Linux.tar.gz.drv'...

***
In order to use NDI SDK version 4.5.1, you need to comply with
NewTek's license and download the appropriate Linux tarball from:

  https://ndi.tv/sdk/

Once you have downloaded the file, please use the following command and
re-run the installation:

  $ nix-prefetch-url file://$PWD/InstallNDISDK_v4_Linux.tar.gz

***

and for tribler, it's test failures in cheroot.

what's up with the backslashes in the links?

zsh messed with me, I'll fix them

@teto teto merged commit 745245a into NixOS:master Jun 17, 2020
@wamserma
Copy link
Member

@teto please also label as security (due to the included CVE-fix)

@teto
Copy link
Member

teto commented Jun 17, 2020

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@progval @evils @wamserma @teto