Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Surelog fails to build becuase cmake is confused about Python version #105

Closed
hzeller opened this issue Jun 16, 2020 · 3 comments · Fixed by #107
Closed

Surelog fails to build becuase cmake is confused about Python version #105

hzeller opened this issue Jun 16, 2020 · 3 comments · Fixed by #107
Assignees
@tgorochowik

Comments

@hzeller
Copy link

hzeller commented Jun 16, 2020

https://travis-ci.com/github/SymbiFlow/conda-packages/jobs/349642231#L3447

Installs Python (gets 3.7.6), later in cmake it has trouble finding it. In fact is claims it finds it, but then also not...

This might be an issue with conflicting Python versions on the build system ? Is there something that needs to be done to have cmake be more robust, or does the CI environment be changed ?

CMake Error at /tmp/really-really-really-really-really-really-really-really-really-really-really-really-really-long-path/conda/conda-bld/surelog_1592301850162/_build_env/share/cmake-3.17/Modules/FindPackageHandleStandardArgs.cmake:164 (message):
3777  Could NOT find Python3 (missing: Python3_EXECUTABLE Interpreter) (found
3778  suitable version "3.7", minimum required is "3.3")
3779Call Stack (most recent call first):
3780  /tmp/really-really-really-really-really-really-really-really-really-really-really-really-really-long-path/conda/conda-bld/surelog_1592301850162/_build_env/share/cmake-3.17/Modules/FindPackageHandleStandardArgs.cmake:445 (_FPHSA_FAILURE_MESSAGE)
3781  /tmp/really-really-really-really-really-really-really-really-really-really-really-really-really-long-path/conda/conda-bld/surelog_1592301850162/_build_env/share/cmake-3.17/Modules/FindPython/Support.cmake:2398 (find_package_handle_standard_args)
3782  /tmp/really-really-really-really-really-really-really-really-really-really-really-really-really-long-path/conda/conda-bld/surelog_1592301850162/_build_env/share/cmake-3.17/Modules/FindPython3.cmake:311 (include)
3783  CMakeLists.txt:45 (find_package)
@hzeller
Copy link
Author

hzeller commented Jun 16, 2020

Tomasz, is this something you see what needs to be fixed ?

@tgorochowik
Copy link
Member

@hzeller I took a log at the differences in logs when it started to fail and in my opinion it failed after adding Windows support to surelog. This change seems to be the culprit:
alainmarcel/Surelog@e63ebbecd#diff-af3b638bc2a3e6c650974192a53c7291R45-R50

@hs-apotell I think you are the author of this. Could you please take a look? I am afraid that simply reverting it may break Windows support.

@tgorochowik tgorochowik mentioned this issue Jun 16, 2020
Closed
@tgorochowik
Copy link
Member

On the other hand I just realized that we successfully build a newer version (I think) of surelog in the uhdm-integration package. After taking a quick look it seems that the python requirement is in another section in meta.yml. We may want to check that (or see if the build flags used there are different than the flags in the vanilla surelog package). Maybe we can get this to work without changing the cmake files in surelog.

hzeller added a commit to hzeller/conda-packages that referenced this issue Jun 17, 2020
@hzeller
Surelog cmake refers to python interpreter at build time, add to yaml.
88802d5 
This fixes SymbiFlow#105

Signed-off-by: Henner Zeller <h.zeller@acm.org>
@hzeller hzeller mentioned this issue Jun 17, 2020
Closed
@tgorochowik tgorochowik mentioned this issue Jun 17, 2020
Merged
hzeller added a commit to hzeller/conda-packages that referenced this issue Jun 23, 2020
@hzeller
Attempt to fix Surelog build: we need python development files.
91f6f25 
Fixes SymbiFlow#105

Signed-off-by: Henner Zeller <h.zeller@acm.org>
@hzeller hzeller mentioned this issue Jun 23, 2020
Closed
@timkpaine timkpaine mentioned this issue Mar 5, 2023
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tgorochowik tgorochowik

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@hzeller @tgorochowik