New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
virtual-ans: init at 3.0.2c #90624
virtual-ans: init at 3.0.2c #90624
Conversation
The checks appear to fail because they are running on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few suggestions :)
Many thanks for your help @IvarWithoutBones! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few more minor nits, otherwise LGTM.
Also, commits should be squashed together into one, with a message following the contributing guidelines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :)
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
there seem to be a lot of unneeded files in the top-level of the generated output. are they really necessary? for example: |
I've hacked together a scheme for removing all |
ah, ic, I thought it was just left over files. You don't need to remove the unneeded files then, since the code seems more complex than having the few files lying around. |
I've shortened and improved the removal logic, so that it should automatically work if darwin is ever enabled. As it stands it will needlessly keep It would be more important to get rid of |
82735bf
to
84bbb10
Compare
With the last change, I think we're now keeping close to the minimum required for any single architecture. |
cool, can you squash the changes into one single commit? no need to keep the history I guess |
Done. |
Thanks @Lassulus for your herculean effort on merging the PR backlog! |
its more of an sisyphean effort :P |
Motivation for this change
No Nix package for virtual-ans exists yet.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)