open-vm-tools: fix build #90626
Merged
open-vm-tools: fix build #90626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,6 +13,7 @@ stdenv.mkDerivation rec { | |||
| repo = "open-vm-tools"; | |||
| rev = "stable-${version}"; | |||
| sha256 = "0idh8dqwb1df2di689090k9x1iap35jk3wg8yb1g70byichmscqb"; | |||
| name = "${pname}-${version}-source"; | |||
There was a problem hiding this comment.
Suggested change
| name = "${pname}-${version}-source"; |
the default name is intentional c3255fe
There was a problem hiding this comment.
My bad I put this in because I screwed up a fetch and needed to force my local env to redo it. Removed.
|
|
||
| patches = [ ./recognize_nixos.patch ]; | ||
| patches = [ ./recognize_nixos.patch ./find_gdk_pixbuf_xlib.patch ]; |
There was a problem hiding this comment.
can reference your upstream patch vmware/open-vm-tools#438 in a comment?
tteggel
force-pushed
the
fix-open-vm-tools-gdk-pixbuf-xlib
branch
from
cee9131
to
071d042
Compare
|
Can you reword your commit header to match contribution guidelines? Like https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes |
tteggel
force-pushed
the
fix-open-vm-tools-gdk-pixbuf-xlib
branch
from
071d042
to
94e7fdf
Compare
|
Commit message fixed @worldofpeace. Thanks for bearing with me. |
|
@tteggel No problem. Thanks for contributing ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes #90544
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)