Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

awscli, boto3, botocore: bump to latest versions #90627

Merged
merged 3 commits into from Jun 16, 2020
Merged

awscli, boto3, botocore: bump to latest versions #90627

merged 3 commits into from Jun 16, 2020

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Jun 16, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Jun 16, 2020

This change is on staging-next, please rebase onto it.

@flokli flokli changed the base branch from master to staging-next June 16, 2020 17:13
@flokli
Copy link
Contributor Author

flokli commented Jun 16, 2020

Well, a slightly different change, but the same packages. Rebased and retargeted to staging-next, squashed and updated the commit messages. PTAL.

@FRidh
Copy link
Member

FRidh commented Jun 16, 2020

@GrahamcOfBorg build python3.pkgs.moto

@flokli
Copy link
Contributor Author

flokli commented Jun 16, 2020

@FRidh is this good to merge?

jonringer
jonringer approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I say this is good, any regressions can be dealt with on staging-next

@flokli flokli merged commit 5815eca into NixOS:staging-next Jun 16, 2020
@flokli
Copy link
Contributor Author

flokli commented Jun 16, 2020

👍

@flokli flokli deleted the awscli-boto-bump branch June 16, 2020 19:15
@flokli flokli mentioned this pull request Jun 18, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flokli @FRidh @jonringer