Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-lambda-builders: 0.8.0 -> 0.9.0; aws-sam-cli: 0.44.0 -> 1.0.0rc1 #90584

Merged
merged 2 commits into from Jul 4, 2020

Conversation

endgame
Copy link
Contributor

@endgame endgame commented Jun 16, 2020

Motivation for this change

The version of aws-sam-cli currently in nixpkgs does not support building runtime: provided functions.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Also tested by building the template.yaml I was working on before I hit this problem.

@scoates
Copy link
Contributor

scoates commented Jun 29, 2020

Full disclosure: I'm not very good at this. (-:

@grahamc called me out because I'd touched this package before. I updated my local to upstream master, cherry picked your commit over top of it and did nix-build -A aws-sam-cli, and ended up in this error:

…
/private/var/folders/tf/z8cw3b514bs2sgsm7vphdmmc0000gn/T/nix-build-python3.8-boto3-1.14.3.drv-0/boto3-1.14.3/dist /private/var/folders/tf/z8cw3b514bs2sgsm7vphdmmc0000gn/T/nix-build-python3.8-boto3-1.14.3.drv-0/boto3-1.14.3
Processing ./boto3-1.14.3-py2.py3-none-any.whl
Requirement already satisfied: s3transfer<0.4.0,>=0.3.0 in /System/Volumes/Data/nix/store/y1yjf5rdnds9ak8yhmp2f7xrqmksxd3c-python3.8-s3transfer-0.3.3/lib/python3.8/site-packages (from boto3==1.14.3) (0.3.3)
ERROR: Could not find a version that satisfies the requirement botocore<1.18.0,>=1.17.3 (from boto3==1.14.3) (from versions: none)
ERROR: No matching distribution found for botocore<1.18.0,>=1.17.3 (from boto3==1.14.3)
builder for '/nix/store/anhiwk8fbcjzx1q4wva1asxm64s13mar-python3.8-boto3-1.14.3.drv' failed with exit code 1
cannot build derivation '/nix/store/bnnvgjg95j1zi9cxjfj8z276zw73k341-python3.8-aws-sam-translator-1.24.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/wd79k27vkidnngdqgcrwr2574ckl1s83-python3.8-serverlessrepo-0.1.10.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/834gplpfnk6lrkl8258cm9zhaqb8yj55-aws-sam-cli-0.52.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/834gplpfnk6lrkl8258cm9zhaqb8yj55-aws-sam-cli-0.52.0.drv' failed

Was hoping to say something more like "I don't know what I'm doing, but it builds and runs for me; ship it!" (-:

Looks like botocore is at 1.17.3 right now…

@endgame
Copy link
Contributor Author

endgame commented Jun 29, 2020

Thank you. I'll investigate.

@endgame endgame changed the title aws-sam-cli: 0.44.0 -> 0.52.0 aws-lambda-builders: 0.8.0 -> 0.9.0; aws-sam-cli: 0.44.0 -> 1.0.0rc1 Jul 4, 2020
@ofborg ofborg bot requested a review from dhl July 4, 2020 10:49
@endgame
Copy link
Contributor Author

endgame commented Jul 4, 2020

Okay, I have this rebased onto master and building under nix-shell -p nixpkgs-review --run "nixpkgs-review pr 90584".

In particular, aws-sam-cli isn't very diligent about staying current with python packages, and many of its bounds are older than what's in nixpkgs. Where the new version doesn't appear to break things (I checked changelogs and PRs), I have relaxed the bounds instead of pulling in old versions. Where the new version appears risky, I have stuck with the existing derivation's approach of pulling in dependencies explicitly.

@FRidh FRidh merged commit 3bdebb0 into NixOS:master Jul 4, 2020
@endgame endgame deleted the update-aws-sam-cli branch July 4, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants