Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tpm2-abrmd: 2.2.0 -> 2.3.2 #90599

Closed

Conversation

lschuermann
Copy link
Member

@lschuermann lschuermann commented Jun 16, 2020

Motivation for this change

Update of the TPM2 userspace resource manager (abrmd). This was originally professionally delayed(TM) by me in #74665. This is a later version and actually works, hence fixes #74665.

It turns out that the upgrade from 2.2.0 indeed breaks the resource manager, as it fails to load the device TCTI from tpm2-tss.

In a debugging effort, tpm2-tss was also upgraded to the latest version. As this was only tested using this specific version of tpm2-tss (and incompatibilities have traditionally been an issue with the TPM2 software stack for me) I'd kindly request to wait for #90595 to be merged first. Accordingly, this PR is based on the commits of #90595.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
nixpkgs-review pr 90599

Result of nixpkgs-review pr 90599 1

8 packages built:
- discover
- fwupd
- gnome-firmware-updater
- gnome3.gnome-software
- tpm2-abrmd
- tpm2-pkcs11
- tpm2-tools
- tpm2-tss

@JohnAZoidberg

@lschuermann lschuermann changed the title Dev/update/tpm2 abrmd 2.3.2 tpm2-abrmd: 2.2.0 -> 2.3.2 Jun 16, 2020
@ofborg ofborg bot requested a review from delroth June 16, 2020 11:32
pkgs/tools/security/tpm2-abrmd/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/tpm2-abrmd/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/tpm2-abrmd/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/tpm2-abrmd/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/tpm2-abrmd/default.nix Show resolved Hide resolved
@JohnAZoidberg
Copy link
Member

Thanks!
I squashed the cleanup commit and ushed as 8e94e61 to a7aab1f.

@lschuermann confirmed to have tested it on private chat.

@JohnAZoidberg JohnAZoidberg mentioned this pull request Jun 17, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants