New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tpm2-abrmd: 2.2.0 -> 2.3.2 #90599
Closed
lschuermann
wants to merge
10
commits into
NixOS:master
from
lschuermann:dev/update/tpm2-abrmd-2.3.2
Closed
tpm2-abrmd: 2.2.0 -> 2.3.2 #90599
lschuermann
wants to merge
10
commits into
NixOS:master
from
lschuermann:dev/update/tpm2-abrmd-2.3.2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lschuermann
force-pushed
the
dev/update/tpm2-abrmd-2.3.2
branch
from
June 16, 2020 11:49
4175726
to
b8f72ff
Compare
JohnAZoidberg
requested changes
Jun 16, 2020
lschuermann
force-pushed
the
dev/update/tpm2-abrmd-2.3.2
branch
from
June 16, 2020 13:15
b8f72ff
to
19e4481
Compare
lschuermann
force-pushed
the
dev/update/tpm2-abrmd-2.3.2
branch
from
June 16, 2020 16:24
19e4481
to
aaf8b2b
Compare
JohnAZoidberg
approved these changes
Jun 17, 2020
Thanks! @lschuermann confirmed to have tested it on private chat. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update of the TPM2 userspace resource manager (
abrmd
). This was originally professionally delayed(TM) by me in #74665. This is a later version and actually works, hence fixes #74665.It turns out that the upgrade from 2.2.0 indeed breaks the resource manager, as it fails to load the
device
TCTI from tpm2-tss.In a debugging effort, tpm2-tss was also upgraded to the latest version. As this was only tested using this specific version of tpm2-tss (and incompatibilities have traditionally been an issue with the TPM2 software stack for me) I'd kindly request to wait for #90595 to be merged first. Accordingly, this PR is based on the commits of #90595.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)nixpkgs-review pr 90599
Result of
nixpkgs-review pr 90599
18 packages built:
- discover
- fwupd
- gnome-firmware-updater
- gnome3.gnome-software
- tpm2-abrmd
- tpm2-pkcs11
- tpm2-tools
- tpm2-tss
@JohnAZoidberg