Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tre-command: 0.2.3 -> 0.3.1 #90576

Merged
merged 1 commit into from Jun 18, 2020
Merged

tre-command: 0.2.3 -> 0.3.1 #90576

merged 1 commit into from Jun 18, 2020

Conversation

dduan
Copy link
Contributor

@dduan dduan commented Jun 16, 2020

Motivation for this change

New tre release: https://github.com/dduan/tre/releases/tag/v0.3.1

Also, change pname to match the actual desired name. Avoid name
conflict with the other (older) package named tre.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Also, change `pname` to match the actual desired name. Avoid name
conflict with the other (older) package named `tre`.
@mweinelt
Copy link
Member

Result of nixpkgs-review pr 90576 1

1 package built:
- tre-command

Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and LGTM. Thanks!

@danieldk danieldk merged commit 6058a76 into NixOS:master Jun 18, 2020
@dduan dduan deleted the tre-0.3.1 branch June 18, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants