Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-exporter: 1.0.0 -> 1.0.1 #90614

Merged
merged 1 commit into from Jun 16, 2020
Merged

node-exporter: 1.0.0 -> 1.0.1 #90614

merged 1 commit into from Jun 16, 2020

Conversation

Frostman
Copy link
Member

@Frostman Frostman commented Jun 16, 2020 •
edited

Motivation for this change

https://github.com/prometheus/node_exporter/releases/tag/v1.0.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

@ofborg ofborg bot requested review from fpletz, benley and globin June 16, 2020 15:20
@mweinelt
Copy link
Member

Result of nixpkgs-review pr 90614 1

1 package built:
- prometheus-node-exporter

@mweinelt
Copy link
Member

@GrahamcOfBorg test prometheus-exporters

mweinelt
mweinelt approved these changes Jun 16, 2020
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! 👍

@Ma27 Ma27 merged commit 88c1878 into NixOS:master Jun 16, 2020
@Frostman Frostman deleted the node-exporter-1.0.1 branch June 17, 2020 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@fpletz fpletz Awaiting requested review from fpletz

@benley benley Awaiting requested review from benley

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Frostman @mweinelt @Ma27