elinks: bump to newest version, thereby making it usable again #90593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| preConfigure = '' | ||
| patchShebangs ./autogen.sh | ||
| ./autogen.sh | ||
| ''; | ||
|
|
||
| meta = { |
There was a problem hiding this comment.
Currently ofborg fails to evaluate this, as maintainers isn't in scope.
Suggested change
| meta = { | |
| meta = with stdenv.lib; { | |
| description = "Full-featured text-mode web browser (package based on the fork felinks)"; | |
| homepage = "https://github.com/rkd77/felinks"; | |
| license = licenses.gpl2; | |
| platforms = platforms.linux; | |
| maintainers = with maintainers; [ iblech ]; | |
| }; |
There was a problem hiding this comment.
Oops, thank you, I added the maintainers field at the last moment and didn't notice that it wasn't in scope. I also tried platforms.unix, I cannot test on macOS, but Hydra can, let's see!
iblech
force-pushed
the
patch-19
branch
2 times, most recently
from
aabd52e
to
0a7ac21
Compare
IvarWithoutBones
approved these changes
Jun 17, 2020
|
Conflicts with master atm. |
|
Thank you @Ma27, I just rebased to latest master and re-tested (alas only on Linux, not on macOS). I believe Borg will test darwin. |
ofborg
bot
added
6.topic: nixos
and removed
2.status: merge conflict
10.rebuild-darwin: 1
10.rebuild-linux: 1
labels
|
@GrahamcOfBorg build elinks |
xeji
suggested changes
Jul 30, 2020
|
Oh, thanks for noticing! I just removed the stray commit. :-) |
xeji
approved these changes
Aug 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
elinks is a text-mode browser from the old times. I vividly remember that it was my main browser at some point. Alas, the current nixpkgs version of elinks is not really usable, as it fails with SSL errors on most sites. You can reproduce this yourself with
or with most any site really.
This pull request packages the newest version, rendering it usable again. Since development of the official elinks repository seems to have paused, this pull request follows Debian in packaging felinks, a fork of elinks. We also adopt Debian's patches which make the build more reproducible and which implement defaults more adapted to today's age (for instance, to honor the caching behavior prescribed by web servers).
Since the nixpkgs package seemed to be unmaintained, I added myself as maintainer.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)