Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssb/patchwork-classic: Remove due to deprecation #90619

Merged
merged 2 commits into from Jun 16, 2020
Merged

ssb/patchwork-classic: Remove due to deprecation #90619

merged 2 commits into from Jun 16, 2020

Conversation

asymmetric
Copy link
Contributor

Motivation for this change

The package is marked as deprecated, and hasn't seen an update in years.

Use ssb-patchwork instead.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@asymmetric
ssb/patchwork-classic: remove
56f04cb 
Marked as deprecated by upstream, hasn't been updated in years.
@asymmetric
ssb-patchwork: move to ssb-patchwork dir
fe26b62 
Since there's no other ssb package anymore (see previous commit),
there's no need to group them together in a common subdirectory.
@asymmetric asymmetric changed the title Remove deprecated ssb/patchwork-classic package ssb/patchwork-classic: Remove due to deprecation Jun 16, 2020
@flokli flokli merged commit 27094ee into NixOS:master Jun 16, 2020
@asymmetric asymmetric deleted the no-ssb-classic branch June 16, 2020 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asymmetric @flokli