Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tpm2-tss: 2.3.2 -> 2.4.1 #90595

Closed
wants to merge 5 commits into from
Closed

tpm2-tss: 2.3.2 -> 2.4.1 #90595

wants to merge 5 commits into from

Conversation

lschuermann
Copy link
Member

@lschuermann lschuermann commented Jun 16, 2020 •
edited

Motivation for this change

Update of the TPM2 software stack.
Originally done as part of investigating the errors in #74665.

This has been both tested to work with the latest version of the abrmd userspace resource manager (2.3.2) as well as the current nixpkgs master version of tpm-tools with the device TCTI.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@JohnAZoidberg

@ofborg ofborg bot requested a review from delroth June 16, 2020 11:11
@lschuermann lschuermann mentioned this pull request Jun 16, 2020
Closed
10 tasks
JohnAZoidberg
JohnAZoidberg approved these changes Jun 16, 2020
View reviewed changes
Copy link
Member

@JohnAZoidberg JohnAZoidberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on x64 NixOS:

Result of nixpkgs-review pr 90595 1

8 package built:
  • discover
  • fwupd
  • gnome-firmware-updater
  • gnome3.gnome-software
  • tpm2-abrmd
  • tpm2-pkcs11
  • tpm2-tools
  • tpm2-tss

@JohnAZoidberg
Copy link
Member

Part of #90599.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delroth delroth Awaiting requested review from delroth

@JohnAZoidberg JohnAZoidberg Awaiting requested review from JohnAZoidberg

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lschuermann @JohnAZoidberg