Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.coveralls: 1.9.2 -> 2.0.0 #90643

Closed
wants to merge 1 commit into from

Conversation

mweinelt
Copy link
Member

Motivation for this change

Something in my system depends on this and the new version is fine with the updated coverage (5.1) we have on master now.

ERROR: Could not find a version that satisfies the requirement coverage<5.0,>=3.6 (from coveralls==1.9.2) (from versions: none)
ERROR: No matching distribution found for coverage<5.0,>=3.6 (from coveralls==1.9.2)

This drops the python2 support.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Drops support for Python 2.
@jonringer
Copy link
Contributor

this is already in staging-next

@mweinelt
Copy link
Member Author

Missed it then. Thanks.

@mweinelt mweinelt closed this Jun 16, 2020
@mweinelt mweinelt deleted the coveralls branch June 16, 2020 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants