Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.canopen: 0.5.1 -> 1.1.0 #90588

Merged
merged 1 commit into from Jul 2, 2020
Merged

pythonPackages.canopen: 0.5.1 -> 1.1.0 #90588

merged 1 commit into from Jul 2, 2020

Conversation

Emantor
Copy link
Member

@Emantor Emantor commented Jun 16, 2020

Motivation for this change

Much newer version available, re-enable tests and use fetchPypi.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Emantor
pythonPackages.canopen: 0.5.1 -> 1.1.0
da1e22f 
Bump version for the python canopen module, move to fetchPypi and
re-enable tests.
@ofborg ofborg bot requested a review from sorki June 16, 2020 08:13
sorki
sorki approved these changes Jun 16, 2020
View reviewed changes
Copy link
Member

@sorki sorki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

Enteee
Enteee approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@Enteee Enteee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/179

jonringer
jonringer approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

failures are broken on target branch

1 package failed to build:
python38Packages.canopen

2 packages built:
python27Packages.canopen python37Packages.canopen

@jonringer jonringer merged commit f32a865 into NixOS:master Jul 2, 2020
@Emantor Emantor deleted the bump/python-canopen branch July 3, 2020 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorki sorki sorki approved these changes

@Enteee Enteee Enteee approved these changes

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Emantor @nixos-discourse @sorki @Enteee @jonringer