Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced uncaught_exception with uncaught_exceptions #3707

Merged
merged 1 commit into from Jun 17, 2020

Conversation

p01arst0rm
Copy link
Contributor

small fix, uncaught_exception is deprecated in favour of uncaught_exceptions.
nothing huge.

@Ericson2314
Copy link
Member

https://en.cppreference.com/w/cpp/error/uncaught_exception It's removed in C++20, in fact.

@edolstra
Copy link
Member

We had to revert this a couple of months ago because it didn't work on macOS yet: 93b1ce1. Maybe it works now.

@Ericson2314
Copy link
Member

Looks like it is passing CI? Maybe switch to 20.03 did the trick.

@edolstra
Copy link
Member

Could be, but the Hydra builders are not running Catalina yet.

@Ericson2314
Copy link
Member

The error message says "introduced in macOS 10.12", so I think just sierra is sufficient? I have no idea what our support window is, however.

@edolstra
Copy link
Member

I think the problem is that the headers are too old, or something.

@Ericson2314
Copy link
Member

In that case, since we are using a nixpkg-provided headers, the builder OS version shouldn't matter so much?

@edolstra
Copy link
Member

Probably, but I don't know how pure the stdenv on darwin is these days.

@Ericson2314
Copy link
Member

I'll go check.

@matthewbauer
Copy link
Member

It might help to add -mmacosx-version-min=10.12 to CFLAGS. I didn't think it was necessary since we set MACOSX_DEPLOYMENT_TARGET elsewhere.

@Ericson2314
Copy link
Member

Ericson2314 commented Jun 17, 2020

Hmm, we have been setting MACOSX_DEPLOYMENT_TARGET to something new enough since NixOS/nixpkgs@f1070ee . Maybe it was the headers version.

In any event, I think we should set up a hydra job for just this branch, or just merge it and one of us can monitor hydra to see what happens.

@edolstra edolstra merged commit 4d5169b into NixOS:master Jun 17, 2020
@edolstra
Copy link
Member

Okay, we'll see what happens :-)

@p01arst0rm
Copy link
Contributor Author

#WorksForMe

@p01arst0rm p01arst0rm deleted the outdated-function-fix branch December 20, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants