New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replaced uncaught_exception with uncaught_exceptions #3707
Conversation
https://en.cppreference.com/w/cpp/error/uncaught_exception It's removed in C++20, in fact. |
We had to revert this a couple of months ago because it didn't work on macOS yet: 93b1ce1. Maybe it works now. |
Looks like it is passing CI? Maybe switch to 20.03 did the trick. |
Could be, but the Hydra builders are not running Catalina yet. |
The error message says "introduced in macOS 10.12", so I think just sierra is sufficient? I have no idea what our support window is, however. |
I think the problem is that the headers are too old, or something. |
In that case, since we are using a nixpkg-provided headers, the builder OS version shouldn't matter so much? |
Probably, but I don't know how pure the stdenv on darwin is these days. |
I'll go check. |
It might help to add |
Hmm, we have been setting In any event, I think we should set up a hydra job for just this branch, or just merge it and one of us can monitor hydra to see what happens. |
Okay, we'll see what happens :-) |
#WorksForMe |
small fix, uncaught_exception is deprecated in favour of uncaught_exceptions.
nothing huge.