tap-plugins: init at 1.0.1 #90580
tap-plugins: init at 1.0.1 #90580
Conversation
pkgs/top-level/all-packages.nix
Outdated
| @@ -20593,6 +20593,8 @@ in | |||
|
|
|||
| caps = callPackage ../applications/audio/caps { }; | |||
|
|
|||
| tap-plugins = callPackage ../applications/audio/tap-plugins { }; | |||
There was a problem hiding this comment.
Please sort this alphabetically.
|
Result of 1 package built:
|
|
Hi! Thanks for your review. I'll see when I find time to incorporate your suggested changes.. |
|
Sorry for being dense. I'm only used to working solo on my own repos. I'll try and sort this out and also add your recommended changes again.. |
|
OK, the project was moved to github in the meantime and had a new release. I packaged the new release from github and tried to address your other comments. |
fps
force-pushed
the
add-tap-plugins
branch
2 times, most recently
from
db7df07
to
cf994d9
Compare
|
@SuperSandro2000 ping :) |
| pname = "tap-plugins"; | ||
| version = "1.0.1"; | ||
|
|
||
| src = fetchurl { |
There was a problem hiding this comment.
Please use fetchFromGitHub.
|
|
||
| buildInputs = [ ladspa-sdk ]; | ||
|
|
||
| installPhase = '' |
There was a problem hiding this comment.
| installPhase = '' | |
| preInstall = '' |
|
|
||
| installPhase = '' | ||
| substituteInPlace Makefile --replace /usr/local "$out" | ||
| INSTALL_PLUGINS_DIR="$out"/lib/ladspa INSTALL_RDF_DIR="$out"/share/ladspa/rdf make install |
There was a problem hiding this comment.
| INSTALL_PLUGINS_DIR="$out"/lib/ladspa INSTALL_RDF_DIR="$out"/share/ladspa/rdf make install | |
| export INSTALL_PLUGINS_DIR="$out"/lib/ladspa | |
| export INSTALL_RDF_DIR="$out"/share/ladspa/rdf |
|
Hi again, thanks for your review. I have tried to incorporate them. The exports were no longer necessary. The makefile patch was enough. |
|
|
||
| src = pkgs.fetchFromGitHub { | ||
| owner = "tomszilagyi"; | ||
| repo = "${pname}"; |
There was a problem hiding this comment.
| repo = "${pname}"; | |
| repo = pname; |
|
Oops, yes, thanks again! |
|
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 1 package built:
|
Motivation for this change
I needed tap-plugins for an experiment I ran. Once I had finished the expression I thought "Why not send a PR to nixpkgs?". So I did.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)