Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coc-nvim: add patch to hardcode node dependency #90579

Closed
wants to merge 325 commits into from
Closed

coc-nvim: add patch to hardcode node dependency #90579

wants to merge 325 commits into from

Conversation

sheeldotme
Copy link

Motivation for this change

Patched to hard code the node path so the vim plugin can find the node binary from the nix store.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Mic92 and others added 20 commits June 16, 2020 07:09
The documentation incorrectly stated that `installFlags` are passed to
`pip install`.
We need to keep the passthru.filesInstalledToEtc and passthru.defaultBlacklistedPlugins in sync with the package contents so let's add a test to enforce that.
nixos/systemd-boot: update bootloader if needed
gitAndTools.git-gone: 0.3.2 -> 0.3.6
graylog-enterprise-integrations: 3.3.0 -> 3.3.1
graylog-integrations: 3.3.0 -> 3.3.1
r-ryantm and others added 21 commits June 17, 2020 12:41
Specifying mailboxes as a list isn't a good approach since this makes it
impossible to override values. For backwards-compatibility, it's still
possible to declare a list of mailboxes, but a deprecation warning will
be shown.
nixos/dovecot2: turn `mailboxes`-option into an attr-set
    /build/doc/manual-full.xml:12764:35: error: ID "build-phase" has already been defined
    /build/doc/manual-full.xml:9029:33: error: first occurrence of ID "build-phase"
agda: fix manual build -- blocks nixpkgs-unstable
matrix-synapse: 1.14.0 -> 1.15.1
maintainers/teams: add matrix team
pantheon.elementary-code: 3.4.0 -> 3.4.1
bat-extras: 20200408 -> 20200515-dev
In /etc/sudoers, the last-matched rule will override all
previously-matched rules. Thus, make the default rule show up first (but
still allow some wiggle room for a user to `mkBefore` it), before any
user-defined rules.
nixos/sudo: default rule should be first
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet