Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

atom: 1.42.0 -> 1.48.0 #90565

Merged
merged 1 commit into from Jun 17, 2020
Merged

atom: 1.42.0 -> 1.48.0 #90565

merged 1 commit into from Jun 17, 2020

Conversation

chkno
Copy link
Member

@chkno chkno commented Jun 16, 2020

And atom-beta: 1.43.0-beta0 -> 1.49.0-beta0

This version bump includes an important python2 -> python3 update:
node-gyp 3.7.0 -> 5.1.0 in Atom's apm/package-lock.json, which, per
nodejs/node-gyp#1687, finally allows python3
to be used instead of EOL'd python2 for atom-package installation.

Motivation for this change

Be able to install atom packages without installing python2, which is 5 months past EOL.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
    typora and termius-app debs could not be fetched. I didn't look into this further because these only build with allowUnfree.
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    1301740784 -> 1308167848 ( +0.5% )
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Maintainers: @offlinehacker @NeQuissimus @ysndr

Note that there is another open Atom version bump PR: #83340 1.42.0 -> 1.45.0.
(Atom needs to get to 1.48 to fix the python2 problem.)

@chkno
atom: 1.42.0 -> 1.48.0
52f1332 
atom-beta: 1.43.0-beta0 -> 1.49.0-beta0

This version bump includes node-gyp 3.7.0 -> 5.1.0 in Atom's
apm/package-lock.json, which, per nodejs/node-gyp#1687
, finally allows python3 to be used instead of EOL'd python2 for
atom-package installation.
@chkno chkno mentioned this pull request Jun 16, 2020
Closed
10 tasks
@marius851000
Copy link
Contributor

marius851000 commented Jun 16, 2020 •
edited

Reviewed points
  • package name fits guidelines
  • package version fits guidelines
  • package build on x86-64
  • executables tested on x86-64 (only for atom, atom-beta, apm, apm-beta, nix-tour and teams)
  • all depending packages build: compilation of hyper-haskell, termius and typora fail (also fail on master)
Possible improvements

use a different environment for compiling atom and electron

Comments

There is a lot of useless rebuild due to atomEnv also being used to compile electron. It may be a good idea to build electron with it's own environment.

@worldofpeace worldofpeace merged commit 3b2cd55 into NixOS:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeQuissimus NeQuissimus NeQuissimus approved these changes

@ysndr ysndr Awaiting requested review from ysndr

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chkno @marius851000 @NeQuissimus @worldofpeace