Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/nvidia: Only install nvidia-persistenced when it is enabled as a service #90639

Closed
wants to merge 1 commit into from
Closed

nixos/nvidia: Only install nvidia-persistenced when it is enabled as a service #90639

wants to merge 1 commit into from

Conversation

eliaslfox
Copy link

@eliaslfox eliaslfox commented Jun 16, 2020 •
edited

Only install nvidia-persistenced by default when hardware.nvidia.nvidiaPersistenced is enabled instead of always.

CC @abbradar

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@eliaslfox
nixos/nvidia: Only install nvidia-persistenced when enabled
95f23fe 
nvidia-persistenced is now only installed when
hardware.nvidia.nvidiaPersistenced is enabled instead of always.
@eliaslfox eliaslfox changed the title nixos/nvidia: Only install nvidia-persistenced when enabled as a service nixos/nvidia: Only install nvidia-persistenced when it is enabled as a service Jun 16, 2020
@hazelweakly
Copy link

PR #100538 is merged now and does the same thing as this.

@stale
Copy link

stale bot commented Jul 21, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 21, 2021
@eliaslfox eliaslfox closed this Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasJ dasJ dasJ approved these changes

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@eliaslfox @hazelweakly @dasJ @SuperSandro2000 @Janik-Haag