Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

melonDS: init at 0.8.3 #90638

Merged
merged 3 commits into from Jun 17, 2020
Merged

melonDS: init at 0.8.3 #90638

merged 3 commits into from Jun 17, 2020

Conversation

benley
Copy link
Member

@benley benley commented Jun 16, 2020

Things done

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@benley
Copy link
Member Author

benley commented Jun 16, 2020

Eep, I just noticed that this is largely a duplicate of #72209. @artemist, should I rebase on your existing PR or just close this one and let you take it over?

@artemist
Copy link
Member

artemist commented Jun 16, 2020

I forgot about that PR and I'm not in a place to fix it. You can take over and I'll close it.

@benley
Copy link
Member Author

benley commented Jun 16, 2020

Will do, thanks!

@benley benley merged commit 11c004f into NixOS:master Jun 17, 2020
@benley benley deleted the benley/melonDS branch June 17, 2020 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants