Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/systemd: Update warning for restarting oneshots #90604

Merged
merged 1 commit into from Jun 16, 2020

Conversation

maralorn
Copy link
Member

Restart= can be anything other than on-success and always for onehost units as of
systemd/systemd@10e7272
which is contained in systemd 245.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli

nixos/modules/system/boot/systemd.nix Outdated Show resolved Hide resolved
Restart= can be anything other than on-success and always for onehost units as of
systemd/systemd@10e7272
which is contained in systemd 245.
@flokli flokli merged commit d725301 into NixOS:master Jun 16, 2020
@maralorn maralorn deleted the systemd-oneshot-warning branch June 16, 2020 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants