Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maintainers/teams: add matrix team #90646

Merged
merged 1 commit into from Jun 17, 2020
Merged

maintainers/teams: add matrix team #90646

merged 1 commit into from Jun 17, 2020

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jun 16, 2020

Motivation for this change

Add a new maintainer-team for packages related to the matrix ecosystem.

⚠️ Note: I mostly added folks who wanted to be part of this team. Anyone else who wants to be a part of that can leave a comment here or file a PR later :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 requested review from bachp and worldofpeace June 16, 2020 22:47
@Ma27 Ma27 mentioned this pull request Jun 16, 2020
Merged
10 tasks
@aanderse
Copy link
Member

Maybe add go-neb?

@vcunat
Copy link
Member

vcunat commented Jun 17, 2020

Detail I noticed: perhaps ping all those removed maintainers, unless you already have input from them? Or always concatenate the team and them?

@Ma27
Copy link
Member Author

Ma27 commented Jun 17, 2020

cc @roblabla @corngood

@roblabla
Copy link
Contributor

Feel free to remove me from the maintainer list. I don't have much time to dedicate to it anymore, sadly.

@Ma27
Copy link
Member Author

Ma27 commented Jun 17, 2020

@worldofpeace @corngood do you want to be part of the matrix-synapse maintainer team?

@corngood
Copy link
Contributor

You can leave me off. I haven't contributed much lately.

Thanks!

@worldofpeace
Copy link
Contributor

@worldofpeace @corngood do you want to be part of the matrix-synapse maintainer team?

I'm a bit overextended lately, but I'm cool being a contributor and reviewing.

@Ma27 Ma27 merged commit 0510cbe into NixOS:master Jun 17, 2020
@Ma27 Ma27 deleted the matrix-maintainer-team branch June 17, 2020 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bachp bachp bachp approved these changes

@Ekleog Ekleog Ekleog approved these changes

@fadenb fadenb fadenb approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@Ma27 @aanderse @vcunat @roblabla @corngood @worldofpeace @bachp @Ekleog @fadenb