Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.MojoliciousPluginAssetPack: init at 2.08 #90600

Merged
merged 3 commits into from Jul 7, 2020
Merged

perlPackages.MojoliciousPluginAssetPack: init at 2.08 #90600

merged 3 commits into from Jul 7, 2020

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Jun 16, 2020 •
edited

This adds the Mojolicious::Plugin::AssetPack perl module.

JavaScriptMinifierXS, CSSMinifierXS are not strictly dependencies, but the module is not particularly useful without them.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@stigtsp stigtsp requested a review from volth June 16, 2020 11:54
@aanderse
Copy link
Member

@GrahamcOfBorg build perlPackages.CSSSass perlPackages.MojoliciousPluginAssetPack
@GrahamcOfBorg build perldevelPackages.CSSSass perldevelPackages.MojoliciousPluginAssetPack

@stigtsp
Copy link
Member Author

stigtsp commented Jun 17, 2020

Darwin fails, I'll update with a fix

@stigtsp stigtsp force-pushed the package/perl-mojolicious-plugin-assetpack-init branch from 60ac0ef to a21fc77 Compare July 6, 2020 13:53
@stigtsp
Copy link
Member Author

stigtsp commented Jul 6, 2020 •
edited

Dropped the CSS::Sass dependency as ExtUtils::CppGuess fails to build on darwin.

@stigtsp stigtsp requested review from volth and aanderse July 6, 2020 13:55
@aanderse
Copy link
Member

aanderse commented Jul 6, 2020 •
edited

@GrahamcOfBorg build perlPackages.MojoliciousPluginAssetPack perldevelPackages.MojoliciousPluginAssetPack

@stigtsp
Copy link
Member Author

stigtsp commented Jul 6, 2020 •
edited

CSS::Minifier::XS and JavaScript::Minifier::XS fails on darwin as well, I'll set up a separate PR add commits that fixes those.

@stigtsp stigtsp force-pushed the package/perl-mojolicious-plugin-assetpack-init branch from a21fc77 to 24cb417 Compare July 6, 2020 15:56
@aanderse aanderse merged commit a1bc66a into NixOS:master Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse Awaiting requested review from aanderse

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stigtsp @aanderse