Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nbconvert: add missing dependency #90629

Closed
wants to merge 1 commit into from
Closed

nbconvert: add missing dependency #90629

wants to merge 1 commit into from

Conversation

mcwitt
Copy link
Contributor

@mcwitt mcwitt commented Jun 16, 2020

Add missing dependency packaging to propagatedBuildInputs.

Motivation for this change

Before this change, building nixpkgs.python3Packages.nbconvert fails with missing dependency:

$ nix-env -f $NIXPKGS -iA pkgs.python3Packages.nbconvert

ERROR: Could not find a version that satisfies the requirement packaging (from bleach->nbconvert==5.6.1) (from versions: none)
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mcwitt
nbconvert: add missing dependency
2e8d454 
Add 'packaging' to propagatedBuildInputs
@FRidh FRidh self-assigned this Jun 17, 2020
@FRidh
Copy link
Member

FRidh commented Jun 17, 2020

nbconvert builds fine for me both on master and staging-next.

What nixpkgs version are you using?

@mcwitt
Copy link
Contributor Author

mcwitt commented Jun 17, 2020 •
edited

What nixpkgs version are you using?

I'm seeing this on current master, 98cac43 (building on Darwin).

Here's a reproduction:

$ git rev-parse HEAD                                                                                                            
98cac435f30251c0c8014440376759b67b3703ba

$ nix-env -f . --no-build-output -iA pkgs.python3Packages.nbconvert                                                                   
installing 'python3.8-nbconvert-5.6.1'
these derivations will be built:
  /nix/store/2r9hy273494bvzzx7dknalms18kx8bmc-python3.8-nbconvert-5.6.1.drv
building '/nix/store/2r9hy273494bvzzx7dknalms18kx8bmc-python3.8-nbconvert-5.6.1.drv'...
builder for '/nix/store/2r9hy273494bvzzx7dknalms18kx8bmc-python3.8-nbconvert-5.6.1.drv' failed with exit code 1; last 10 log lines:
  Requirement already satisfied: bleach in /nix/store/nmnh2x9l3554i4bnvrc4snlavkkr7dxn-python3.8-bleach-3.1.5/lib/python3.8/site-packages (from nbconvert==5.6.1) (3.1.5)
  Requirement already satisfied: jinja2>=2.4 in /nix/store/k8rpybz8lwsh459fn2nxxv4j66cz8afl-python3.8-Jinja2-2.11.2/lib/python3.8/site-packages (from nbconvert==5.6.1) (2.11.2)
  Requirement already satisfied: mistune<2,>=0.8.1 in /nix/store/c748c2grgqicyrbq7pzdgypwy0ng9v2p-python3.8-mistune-0.8.4/lib/python3.8/site-packages (from nbconvert==5.6.1) (0.8.4)
  Requirement already satisfied: jupyter-core in /nix/store/46h72x5wm15qyzj6nnmycm8rb7b232x6-python3.8-jupyter_core-4.6.3/lib/python3.8/site-packages (from nbconvert==5.6.1) (4.6.3)
  Requirement already satisfied: nbformat>=4.4 in /nix/store/k6ndshbinc8ip47vn31krhmiwrbsivzq-python3.8-nbformat-5.0.6/lib/python3.8/site-packages (from nbconvert==5.6.1) (5.0.6)
  Requirement already satisfied: traitlets>=4.2 in /nix/store/wn71v632by345hgsy056273i33ki4yqc-python3.8-traitlets-4.3.3/lib/python3.8/site-packages (from nbconvert==5.6.1) (4.3.3)
  Requirement already satisfied: entrypoints>=0.2.2 in /nix/store/xkv0swvy01apjsiwdl7rax8k2kdlx8fs-python3.8-entrypoints-0.3/lib/python3.8/site-packages (from nbconvert==5.6.1) (0.3)
  Requirement already satisfied: defusedxml in /nix/store/079mnjz1w3p83r83hl7sn6r43iyscv82-python3.8-defusedxml-0.6.0/lib/python3.8/site-packages (from nbconvert==5.6.1) (0.6.0)
  ERROR: Could not find a version that satisfies the requirement packaging (from bleach->nbconvert==5.6.1) (from versions: none)
  ERROR: No matching distribution found for packaging (from bleach->nbconvert==5.6.1)
error: build of '/nix/store/2r9hy273494bvzzx7dknalms18kx8bmc-python3.8-nbconvert-5.6.1.drv' failed
nix-info output
  • system: "x86_64-darwin"
  • host os: Darwin 19.4.0, macOS 10.15.4
  • multi-user?: yes
  • sandbox: no
  • version: nix-env (Nix) 2.3.6
  • channels(matt): "darwin, home-manager"
  • channels(root): "nixpkgs-20.09pre229671.9d0c3ffe678, darwin, home-manager"
  • nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixpkgs

@FRidh
Copy link
Member

FRidh commented Jun 17, 2020 •
edited

According to the error its the package bleach that is missing the dependency.
Proposed fix #90678, please test it.
Interesting though that somehow the dependency is passed through via other dependencies for Linux but not Darwin.

@FRidh FRidh closed this Jun 17, 2020
@mcwitt
Copy link
Contributor Author

mcwitt commented Jun 17, 2020 •
edited

Interesting though that somehow the dependency is passed through via other dependencies for Linux but not Darwin.

Yeah, also interesting that pkgs.python.bleach seems to build fine on its own, but not as a dependency. The following is successful for me:

$ nix-env -f . -iA pkgs.python3Packages.bleach

EDIT: answered here: #90678 (comment)

@mcwitt mcwitt mentioned this pull request Jun 17, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees

@FRidh FRidh

Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mcwitt @FRidh