Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python-language-server: 3.8 fixes + deps #90616

Merged
merged 5 commits into from Jun 16, 2020
Merged

python-language-server: 3.8 fixes + deps #90616

merged 5 commits into from Jun 16, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jun 16, 2020 •
edited

Motivation for this change

I have not tested what these bumps have broken elsewhere.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Jun 16, 2020

Parts are already in staging-next

@Mic92
Copy link
Member Author

Mic92 commented Jun 16, 2020

mhm. I suppose python3.8 should have waited until staging-next was ready?

@Mic92 Mic92 changed the base branch from master to staging-next June 16, 2020 15:55
@Mic92 Mic92 removed the request for review from bjornfor June 16, 2020 16:00
@ofborg ofborg bot requested a review from cillianderoiste June 16, 2020 16:07
@Mic92 Mic92 removed the request for review from cillianderoiste June 16, 2020 16:08
@Mic92
Copy link
Member Author

Mic92 commented Jun 16, 2020 •
edited

Rebased and fixed now.

@FRidh FRidh merged commit 5d6f47c into NixOS:staging-next Jun 16, 2020
@ofborg ofborg bot requested a review from cillianderoiste June 16, 2020 16:16
@Mic92 Mic92 deleted the pyls-fixes branch June 16, 2020 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @FRidh