Replace vscode-extensions.ms-vscode.Go with vscode-extensions.golang.Go #90615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 20, 2020 14:00
According to the README.md: "This is the new home for the VS Code Go extension. We just migrated from Microsoft/vscode-go. Learn more about our move on the Go blog." See also: https://blog.golang.org/vscode-go.
priegger
force-pushed
the
fix/vscode-extensions.golang.Go
branch
from
a80c735
to
1e20aa0
Compare
ofborg
bot
added
8.has: clean-up
8.has: package (new)
10.rebuild-linux: 1-10
10.rebuild-linux: 1
and removed
2.status: merge conflict
10.rebuild-linux: 0
labels
10 tasks
|
is this up-to-date? |
jonringer
approved these changes
Nov 20, 2020
There was a problem hiding this comment.
LGTM, eventually I would like to have something like vimPlugins, but that will probably be for a future date
https://github.com/NixOS/nixpkgs/pull/90615
1 package built:
vscode-extensions.golang.Go
$ nix-shell /home/jon/.cache/nixpkgs-review/pr-90615/shell.nix
[nix-shell:~/.cache/nixpkgs-review/pr-90615]$ nix-build ./nixpkgs/ -A vscode-extensions.ms-vscode.Go
/nix/store/swc2zgk86cl60bd81xyqcgbqlr9qj371-vscode-extension-golang-Go-0.18.1
|
The merging of the aliases is wrong and causes #104783. Sorry about that. I can have a look in ~2 hours, I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
From the README.md on https://github.com/golang/vscode-go:
"This is the new home for the VS Code Go extension. We just migrated from Microsoft/vscode-go. Learn more about our move on the Go blog."
Things done
I removed the old extension and replaced it with an alias to the new one. Unfortunately this leads to a lot of reformatting and noise (I used nixpkgs-fmt to fix the indentation).
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)