Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python2Packages: default to dontUsePythonRecompileBytecode = true; #90636

Merged
merged 27 commits into from Jun 17, 2020
Merged

python2Packages: default to dontUsePythonRecompileBytecode = true; #90636

merged 27 commits into from Jun 17, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jun 16, 2020 •
edited

Motivation for this change

Help alleviate some of the pain around python2, just disable recompiling the bytecode, as many packages either contain python3-only test or sample code.

related: #90447

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from FRidh as a code owner June 16, 2020 20:05
@jonringer
pythonPackages.JPype: disable for python2
9ef6349 
setup.py is no longer python2 compatible
@jonringer
pythonPackages.astral: disable for python2
d5ca07e 
```
  Processing ./astral-2.2-py2-none-any.whl
  ERROR: Package 'astral' requires a different Python: 2.7.18 not in '>=3.6'
```
@jonringer
pythonPackages.av: disable for python2
8db288e 
Uses shlex commands which aren't present in python2
```
      from shlex import quote
  ImportError: cannot import name quote
```
@jonringer
pythonPackages.auth0-python: fix tests
625653c
@jonringer
pythonPackages.avro: fix build
c3597a1
@jonringer
pythonPackages.base58: disable python2
fe1a38a 
python2 abandoned upstream
@jonringer
pythonPackages.cfgv: disable python2, abandoned
3701913
@jonringer
pythonPackages.cloudpickle: disable python2, abandoned
03b2293
@jonringer
Copy link
Contributor Author

also using this for some branch stabilization, as there's less noise from non-python packages

@ofborg ofborg bot requested a review from costrouc June 16, 2020 20:54
@jonringer
Copy link
Contributor Author

that's all the fixing I care to do right now

@ofborg ofborg bot requested review from peterhoeg and johbo June 16, 2020 21:28
@FRidh FRidh merged commit c610d82 into NixOS:staging-next Jun 17, 2020
@FRidh
Copy link
Member

FRidh commented Jun 17, 2020

Thanks!

@jonringer jonringer deleted the disable-byterecompile-py2 branch June 17, 2020 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@costrouc costrouc Awaiting requested review from costrouc

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

@johbo johbo Awaiting requested review from johbo

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 501+ 10.rebuild-darwin: 2501-5000 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @FRidh