Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CF Checker and its cfunits dependency #90606

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add CF Checker and its cfunits dependency #90606

wants to merge 2 commits into from

Conversation

jshholland
Copy link
Contributor

Motivation for this change

Add a package that I use and its dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I'm not 100% sure if I've gone about fixing the path to libudunits.so in cfunits the right way, or whether I have categorised properly. CF conventions are used in atmospheric modelling, but I feel like cfchecker is not "large" enough to fit into applications/science and is more of a "tool".

Also, this currently doesn't build on master due to coveralls being broken there (see e.g. https://hydra.nixos.org/build/121765313)

@jshholland
Copy link
Contributor Author

I just spotted that my editor automatically removed a stray trailing space in all-packages.nix. I can re-submit this PR without that if you would prefer.

@jshholland
Copy link
Contributor Author

Rebased on current master. At some point that stray space got cleaned up so it's no longer part of the changes here.

@stale
Copy link

stale bot commented Apr 18, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 18, 2021
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 29, 2022
hraban
hraban approved these changes Feb 25, 2024
View reviewed changes
Copy link
Contributor

@hraban hraban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

not super familiar with python & nixpkgs so my approval might not be worth much but since you labelled yourself as a maintainer I'm sure you can handle whatever problems arise 🤷

@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hraban hraban hraban approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer 12.approvals: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jshholland @hraban @ryantm @wegank @Janik-Haag