Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minikube: 1.10.0 -> 1.10.1 #87713

Merged
merged 1 commit into from May 13, 2020
Merged

minikube: 1.10.0 -> 1.10.1 #87713

merged 1 commit into from May 13, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented May 13, 2020

https://github.com/kubernetes/minikube/releases/tag/v1.10.1

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zowoq
Copy link
Contributor Author

zowoq commented May 13, 2020

@ofborg build docker-machine-kvm2

@zowoq
Copy link
Contributor Author

zowoq commented May 13, 2020

Could someone trigger a darwin build please?

@ofborg build minikube docker-machine-hyperkit

@marsam
Copy link
Contributor

marsam commented May 13, 2020

@ofborg build minikube docker-machine-hyperkit

@marsam marsam merged commit d5a8dc3 into NixOS:master May 13, 2020
@zowoq zowoq deleted the minikube branch May 13, 2020 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants