Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport: visidata is supported on darwin + add setuptools #87743

Merged
merged 2 commits into from May 13, 2020
Merged

backport: visidata is supported on darwin + add setuptools #87743

merged 2 commits into from May 13, 2020

Conversation

badmutex
Copy link
Contributor

Motivation for this change

Use visidata on darwin. This brings the 20.03 branch up to date with master.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

teto and others added 2 commits May 13, 2020 09:43
@teto
visidata: add setuptools
3310a6b 
and ran nixpkgs-fmt.

This allows to access visidata's help via ctrl+H.

(cherry picked from commit d21cf30)
@badmutex
visidata: add darwin to supported platforms
05d17d0 
(cherry picked from commit b332947)
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 8.has: package (new) labels May 13, 2020
@ofborg ofborg bot requested a review from 7c6f434c May 13, 2020 14:57
@7c6f434c 7c6f434c merged commit bd561f6 into NixOS:release-20.03 May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@badmutex @7c6f434c @teto