Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.jingoo: 1.2.18 → 1.3.4 #87765

Merged
merged 1 commit into from May 14, 2020

Conversation

sternenseemann
Copy link
Member

Motivation for this change

Update package, switch to dune build system.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Also tested own project that depends on jingoo.

@sternenseemann
Copy link
Member Author

@GrahamcOfBorg build ocamlPackages.jingoo

@vbgl
Copy link
Contributor

vbgl commented May 14, 2020

@GrahamcOfBorg build ocamlPackages.jingoo

@vbgl vbgl merged commit 9d55751 into NixOS:master May 14, 2020
@sternenseemann sternenseemann deleted the ocaml-jingoo-1.3.4 branch May 14, 2020 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants