Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vim-beancount: fix broken #87756

Merged
merged 1 commit into from Jun 23, 2020
Merged

vim-beancount: fix broken #87756

merged 1 commit into from Jun 23, 2020

Conversation

siriobalmelli
Copy link
Contributor

Signed-off-by: Sirio Balmelli sirio@b-ad.ch

Motivation for this change

vim-beancount package would fail to invoke autocompletion at runtime with: ModuleNotFoundError: No module named 'beancount'

Things done

Add python3 dependency to vim-beancount override.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@siriobalmelli siriobalmelli force-pushed the fix/vim-beancount branch 2 times, most recently from 143b273 to 4072839 Compare May 27, 2020 13:59
@siriobalmelli siriobalmelli force-pushed the fix/vim-beancount branch 2 times, most recently from fe310c8 to 9b4f9a9 Compare June 8, 2020 13:18
@siriobalmelli siriobalmelli force-pushed the fix/vim-beancount branch 2 times, most recently from 5083dcf to a331b41 Compare June 13, 2020 15:22
@siriobalmelli siriobalmelli force-pushed the fix/vim-beancount branch 2 times, most recently from 54d644f to 305d3b3 Compare June 19, 2020 17:23
@siriobalmelli siriobalmelli changed the title vim-beancount: dependency on python3 'beancount' package vim-beancount: fix broken Jun 20, 2020
@siriobalmelli
vim-beancount: fix broken
ffb2108 
Runtime dependency on python3 'beancount' package needed
for autocompletion engine.

Signed-off-by: Sirio Balmelli <sirio@b-ad.ch>
@siriobalmelli
Copy link
Contributor Author

siriobalmelli commented Jun 23, 2020 •
edited

This pull request has been open since 13 May.

Would be great to be able to get it merged and stop tracking and periodically rebasing a separate branch in my repo.

I've gone through CONTIBUTING.md a couple times and if there's something I should be doing to improve this pull request I don't see it.

Any feedback is much appreciated.

... I can assure you the fix is stable, I daily-drive Vim with this plugin enabled.

@jonringer
Copy link
Contributor

jonringer commented Jun 23, 2020 •
edited

diff LGTM, sorry i didn't get around to it sooner

jonringer
jonringer approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 87756 1

@jonringer jonringer merged commit d5b6a9c into NixOS:master Jun 23, 2020
@siriobalmelli
Copy link
Contributor Author

diff LGTM, sorry i didn't get around to it sooner

No worries - and I notice you handle a lot of the package review for Nix!
That's certainly much appreciated.

@siriobalmelli siriobalmelli deleted the fix/vim-beancount branch June 24, 2020 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
6.topic: vim 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@siriobalmelli @jonringer