Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various window managers #87716

Merged
merged 4 commits into from May 15, 2020
Merged

Various window managers #87716

merged 4 commits into from May 15, 2020

Conversation

AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented May 13, 2020

Motivation for this change

Introduce various small window managers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

{
###### interface
options = {
services.xserver.windowManager.lwm.enable = mkEnableOption "lwm";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a more descriptive text for the option is a good idea.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How could it be done?

I'm just using a small template I have used in Ouroboros...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may use a string similar to the description meta attribute of the respective package as the argument for mkEnableOption, instead of using only the window manager name.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do it in a "treewide" fashion.

yeahwm is a small window manager for X11, inspired by evilwm
berry is a small window manager for X11
lwm is a lightweight window manager
@AndersonTorres AndersonTorres merged commit 0687add into NixOS:master May 15, 2020
@AndersonTorres AndersonTorres deleted the weird-window-mangers-upload branch May 15, 2020 01:22
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request May 15, 2020
…rs-upload

Small window managers:

- berry: init at 0.1.5
- smallwm: init at 2020-02-28
- yeahwm: init at 0.3.5
- lwm: init at 1.2.4

(cherry picked from commit 0687add)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants