Add flake8 linter #1343
Merged
Add flake8 linter #1343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mainly an addition to avoid import loops by detecting unused imports early and force them to be removed. Flake8 also detects other things which may be of interest of us such as bad variable naming, function complexity (this one is of great interest). We opt out of a number of checks that conflict with black's auto formatting rules.
|
Ratchet is whatever, but the requirements.txt for the docs is out of date |
|
Ignoring the ratchet since this is strictly an improvement, and a few deleted imports shouldn't be penalized. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly an addition to avoid import loops by detecting unused imports early and force them to be removed.
Flake8 also detects other things which may be of interest of us such as bad variable naming, cyclomatic complexity (this one is of great interest to me at least).
We opt out of a number of checks that conflict with black's auto formatting rules.