New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ubertooth package and module #87750
Ubertooth package and module #87750
Conversation
@GrahamcOfBorg build ubertooth |
Result of 1 package blacklisted:- tests.nixos-functions.nixos-test 2 packages built:- libbtbb - ubertooth |
I updated this PR and made it Linux-exclusive. I would be very happy to see this one merged and to deal with further PRs regarding macOS compatibility. |
07e3cf2
to
7c540fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about the group option. The rest looks okay.
Result of nixpkgs-review pr 87750
1
1 package blacklisted:
- tests.nixos-functions.nixos-test
2 packages built:
- libbtbb
- ubertooth
options.hardware.ubertooth = { | ||
enable = mkEnableOption "Enable the Ubertooth software and its udev rules."; | ||
|
||
group = mkOption { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure the group option provides much value, when users need to add themselves to the group manually anyway, which in turn would also create the group.
users.groups.ubertooth.members = [ "me" ];
A better option would IMO be one to specify users that will be added to the ubertooth group.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the one hand this is probably true, however, I have tried to adapt to other hardware modules. Most modules are just specifying a fixed group (e.g. acpilight
, bladeRF
, brillo
). However, some modules are making this group configurable, e.g., nitrokey
.
Specifying a list of users would be a third way in which the use of different modules differs even more. So I wouldn't find it so appropriate. Should I just configure a fixed group then?
I have updated both |
LGTM |
@@ -0,0 +1,34 @@ | |||
{ stdenv, lib, fetchFromGitHub, cmake, pkgconfig, libbtbb, libpcap , libusb1, bluez |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pkgconfig -> pkg-config, fixed in #118330
Motivation for this change
Add the host driver for an Ubertooth as a package and a module. Therefore, the required
libbtbb
is added first.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)