Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] silence warning from #63103 in encrypted-devices.nix #86567

Merged
merged 1 commit into from Jun 18, 2020
Merged

[20.03] silence warning from #63103 in encrypted-devices.nix #86567

merged 1 commit into from Jun 18, 2020

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented May 2, 2020

Backport of #80504.

Motivation for this change

At least one 20.03 user was confused by the warning they didn't cause.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmilata mmilata added the 8.has: port to stable A PR already has a backport to the stable release. label May 2, 2020
@nagisa nagisa mentioned this pull request May 26, 2020
Closed
10 tasks
@worldofpeace worldofpeace merged commit 52ff653 into NixOS:release-20.03 Jun 18, 2020
@mmilata mmilata deleted the 20.03/encrypted-devices-loaof-warning branch June 18, 2020 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mmilata @worldofpeace @ben0x539