[20.03] libvorbis: fix 404'ing patch #86485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also use full commit for the other patch, just in case there's ever a collision, as unlikely as that may be. (cherry picked from commit f02e1c2)
ehmry
approved these changes
May 1, 2020
Sorry for not answering this question earlier. My understanding is that there is not much point in applying changes that cause rebuilds to those older branches. That requires extra work that is usually done by other community members. That includes actually testing these backports or making sure that the channels are not blocked or managing the staging workflow. |
|
So, correct me if I'm wrong, this is the only necessary backport? |
|
Yes, we want all the fixes to be backported to the current stable release. There aren't such expectations about the EOL releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also use full commit for the other patch, just in case there's ever a
collision, as unlikely as that may be.
(cherry picked from commit f02e1c2)
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)cc @veprbl -- Should 19.03 go to staging-19.03 or release-19.03, considering it's EOL? And should 19.09 go to release-19.09, or staging-19.09?