Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gzip: add setup-hook to stop gzip from adding timestamps to headers #86493

Merged
merged 1 commit into from May 11, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented May 1, 2020

Motivation for this change

This will hopefully help with reproducible builds.

See #86348 for more info

Closes #86348

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented May 1, 2020

Correct, although the idiomatic way would be to use the setupHook attribute.

@prusnak
Copy link
Member Author

prusnak commented May 1, 2020

Thanks, fixed in c4d1b5b

@prusnak prusnak force-pushed the gzip-reproducible branch 2 times, most recently from 036e3d0 to adf6fe4 Compare May 1, 2020 20:26
@FRidh FRidh merged commit a9d9027 into NixOS:staging May 11, 2020
@prusnak prusnak deleted the gzip-reproducible branch May 11, 2020 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants