php.extensions.rdkafka: init at 4.0.3 #86492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etu
force-pushed
the
php-extension-init-rdkafka
branch
from
6d33861
to
5df9d34
Compare
etu
changed the title
ofborg
bot
added
11.by: package-maintainer
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
labels
etu
force-pushed
the
php-extension-init-rdkafka
branch
from
5df9d34
to
a13be9f
Compare
|
@ofborg build php74.extensions.rdkafka php73.extensions.rdkafka php72.extensions.rdkafka |
aanderse
reviewed
May 1, 2020
|
|
||
| postPhpize = '' | ||
| substituteInPlace configure \ | ||
| --replace 'SEARCH_PATH="/usr/local /usr"' 'SEARCH_PATH=${pkgs.rdkafka}' |
There was a problem hiding this comment.
Maybe a regex that looks for a line starting with SEARCH_PATH would be more robust.
There was a problem hiding this comment.
It's also more complex to read, they have had the same SEARCH_PATH as a result from 3.0.3 to 4.0.3, so it doesn't seem to change that much.
Also, if it would fail to build. It's easy to spot that during the package update.
etu
force-pushed
the
php-extension-init-rdkafka
branch
from
a13be9f
to
e683f5c
Compare
|
@ofborg build php.extensions.rdkafka |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Added by request from @alebon. This fixes #86463
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)