New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20.03] zoom-us updates #86502
Merged
Merged
[20.03] zoom-us updates #86502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoom-us: fix launch Probably due to glibc update, ZoomLauncher became broken when v4l is present in LD_PRELOAD path. It can be fixed by a) removing ZoomLauncher from startup chain, so `zoom` is started directly or b) removing v4l from LD_PRELOAD. The reason v4l was added before was because my video was rotated upside down without it. Seem like nowadays this is fixed by Zoom itself, so I'm removing it. Fixes NixOS#79954 Co-authored-by: @mmlb (cherry picked from commit 854638e)
(cherry picked from commit da84ff3)
(cherry picked from commit 8f3f727)
(cherry picked from commit 33c04ea)
(cherry picked from commit 1ccc73c)
(cherry picked from commit 66172a2)
(cherry picked from commit f47e15a)
(cherry picked from commit c4c017f)
(cherry picked from commit f6a53ee)
(cherry picked from commit de2b314)
(cherry picked from commit c56c72b)
worldofpeace
requested review from
adisbladis,
alyssais,
andir,
cdepillabout,
edolstra,
Ericson2314,
etu,
FRidh,
infinisil,
jonringer,
LnL7,
matthewbauer,
Mic92,
nbp,
peti,
Profpatsch,
tfc,
thoughtpolice and
ttuegel
as code owners
May 1, 2020 22:15
ofborg
bot
added
8.has: changelog
8.has: documentation
8.has: module (update)
2.status: merge conflict
and removed
6.topic: TeX
Issues regarding texlive and TeX in general
6.topic: emacs
6.topic: GNOME
GNOME desktop environment and its underlying platform
6.topic: golang
6.topic: haskell
6.topic: lua
6.topic: nixos
6.topic: pantheon
The Pantheon desktop environment
6.topic: policy discussion
6.topic: python
6.topic: qt/kde
6.topic: ruby
6.topic: rust
6.topic: xfce
The Xfce Desktop Environment
8.has: changelog
8.has: documentation
8.has: module (update)
2.status: merge conflict
labels
May 1, 2020
jonringer
approved these changes
May 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff LGTM
gui launches fine
https://github.com/NixOS/nixpkgs/pull/86502
1 package built:
zoom-us
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)