Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

woeusb,jetbrains,ark: prune p7zip #86497

Merged
3 commits merged into from May 2, 2020
Merged

woeusb,jetbrains,ark: prune p7zip #86497

3 commits merged into from May 2, 2020

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented May 1, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@eadwu eadwu requested review from edwtjo and ttuegel as code owners May 1, 2020 20:07
@eadwu
Copy link
Member Author

eadwu commented May 1, 2020 •
edited

woeusb -> patch using 7z is broken now, though there's a warning about that [1]
jetbrains -> didn't find anything using 7z during the build
ark -> pretty sure it'll search the $PATH anyway

[1] https://github.com/slacka/WoeUSB/blob/f21bb19e6aa575682b84c4e909e6509b04aa58e2/src/woeusb#L1571

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/p7zip-and-possible-rces/6951/6

@ghost
Copy link

ghost commented May 2, 2020

Built all three and tested functionality of ark and jetbrains 👍

@ghost ghost merged commit 06fa14f into NixOS:master May 2, 2020
@eadwu eadwu deleted the p7zip/fallout-1 branch November 17, 2020 23:33
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwtjo edwtjo Awaiting requested review from edwtjo edwtjo is a code owner

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

Assignees
No one assigned
Labels
6.topic: qt/kde 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eadwu @nixos-discourse