New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add section on running ad-hoc Perl programs to the nixpkgs manual #86589
doc: add section on running ad-hoc Perl programs to the nixpkgs manual #86589
Conversation
/marvin opt-in |
Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here. |
Looks like I missed one bot error due to the issue yesterday. |
<programlisting> | ||
foo = import ../path/to/foo.nix { | ||
inherit stdenv fetchurl ...; | ||
inherit (perlPackages) ClassC3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have a perlPackages.callPackage scope like we do have for python?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually we do...
foo = perlPackages.callPackage ./path/to/foo.nix {};
should fill out:
{ ClassC3 }:
# ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not actually sure which section was actually changed so I read the whole article.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See @Mic92's feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All in all this section is not really perl specific. But I suppose it can't hurt to have a section in the perl docs, if the pattern is particularly common there.
I don't understand where all the unrelated whitespace changes come from. |
The 'Perl' section used to consist of a number of sections on different ways of packaging Perl applications. In this PR, I put those under a 'Packaging Perl programs' section (added a 'Running Perl programs' section before it). Because of that, all the sections on packaging were indented 1 level. |
3e64e99
to
0c8047a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I missed that the "Packaging" part was top-level before. Two more small nitpicks, one of which is on my own suggestion.
Co-authored-by: Timo Kaufmann <timokau@zoho.com>
0c8047a
to
6093372
Compare
Thanks! |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)