Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite release workflow #113

Merged
merged 6 commits into from May 1, 2020
Merged

Conversation

LordAro
Copy link
Member

@LordAro LordAro commented May 1, 2020

Split up the release workflow into separate jobs, as trying to keep them together was just making things difficult to read.
Now builds source tarball with MacOS to get that LF line ending goodness

Seems to still work - https://github.com/LordAro/nml/actions/runs/93337764 - they all failed, but that's just because they don't have permission to upload to PyPI :)

@LordAro LordAro requested review from TrueBrain and glx22 May 1, 2020 19:33
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
TrueBrain
TrueBrain previously approved these changes May 1, 2020
Copy link
Member

@TrueBrain TrueBrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content wise I have no opinion, and the rest LGTM!

@LordAro LordAro merged commit a62638f into OpenTTD:master May 1, 2020
@LordAro LordAro deleted the rewrite-release-workflow branch May 1, 2020 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants