New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite release workflow #113
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordAro
force-pushed
the
rewrite-release-workflow
branch
from
May 1, 2020 20:11
9ed305d
to
32c1bf5
Compare
LordAro
force-pushed
the
rewrite-release-workflow
branch
from
May 1, 2020 20:20
32c1bf5
to
0c08b37
Compare
TrueBrain
previously approved these changes
May 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content wise I have no opinion, and the rest LGTM!
TrueBrain
approved these changes
May 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split up the release workflow into separate jobs, as trying to keep them together was just making things difficult to read.
Now builds source tarball with MacOS to get that LF line ending goodness
Seems to still work - https://github.com/LordAro/nml/actions/runs/93337764 - they all failed, but that's just because they don't have permission to upload to PyPI :)