Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enlightenment.efl: 1.23.3 -> 1.24.0; new test module #86519

Merged
merged 7 commits into from May 7, 2020
Merged

enlightenment.efl: 1.23.3 -> 1.24.0; new test module #86519

merged 7 commits into from May 7, 2020

Conversation

romildo
Copy link
Contributor

@romildo romildo commented May 2, 2020 •
edited

Motivation for this change
  • enlightenment.efl: format with nixpkgs-fmt
  • enlightenment.efl: 1.23.3 -> 1.24.0
  • enlightenment.efl: migrate to python3
  • enlightenment.econnman: migrate to python3
  • pythonPackages.pythonefl: format
  • pythonPackages.python-efl: 1.23.0 -> 1.24.0

Added:

  • nixos/tests: add enlightenment desktop environment
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@romildo romildo changed the title enlightenment.efl: 1.23.3 -> 1.24.0 enlightenment.efl: 1.23.3 -> 1.24.0; add test module for enlightenment May 3, 2020
@ofborg ofborg bot added the 6.topic: nixos label May 3, 2020
@romildo
Copy link
Contributor Author

romildo commented May 3, 2020

@GrahamcOfBorg test enlightenment

@romildo romildo requested a review from worldofpeace May 3, 2020 02:31
@romildo romildo changed the title enlightenment.efl: 1.23.3 -> 1.24.0; add test module for enlightenment enlightenment.efl: 1.23.3 -> 1.24.0; new test module May 3, 2020
jonringer
jonringer reviewed May 3, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for python-modules, generally you will import the individual python package, instead of pulling them off of the python.pkgs attr. Allows for overriding that one package.

pkgs/development/python-modules/python-efl/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/python-efl/default.nix Show resolved Hide resolved
@jonringer
Copy link
Contributor

The fixup should be squashed into the pythonPackages.python-efl: 1.23.0 -> 1.24.0 commit

@romildo
Copy link
Contributor Author

romildo commented May 5, 2020

The fixup should be squashed into the pythonPackages.python-efl: 1.23.0 -> 1.24.0 commit

Done.

@romildo romildo merged commit 9e1975b into NixOS:master May 7, 2020
@romildo romildo deleted the upd.efl branch May 7, 2020 13:52
@emilazy emilazy mentioned this pull request May 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@FRidh FRidh Awaiting requested review from FRidh

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
6.topic: nixos 6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romildo @jonringer