Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] terminator: 1.91 -> 1.92 #86490

Merged
merged 2 commits into from May 1, 2020
Merged

[20.03] terminator: 1.91 -> 1.92 #86490

merged 2 commits into from May 1, 2020

Conversation

SFrijters
Copy link
Member

Motivation for this change

Backport of #86462 .

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SFrijters and others added 2 commits May 1, 2020 19:59
@SFrijters
terminator: 1.91 -> 1.92
859b119 
(cherry picked from commit 8855c3a)
@jtojnar @SFrijters
terminator: clean up
bc0056d 
(cherry picked from commit 64c09a3)
@SFrijters SFrijters mentioned this pull request May 1, 2020
Closed
@SFrijters
Copy link
Member Author

Note that a fix was made after the original PR was closed, so this consists of two cherry-picked commits.

@SFrijters SFrijters requested a review from jtojnar May 1, 2020 18:06
@ofborg ofborg bot requested a review from bjornfor May 1, 2020 18:13
@veprbl veprbl linked an issue May 1, 2020 that may be closed by this pull request
Terminator is not rendering URLs with links #86049
Closed
@bjornfor bjornfor merged commit 0768366 into NixOS:release-20.03 May 1, 2020
@SFrijters SFrijters deleted the 20.03-terminator3 branch September 30, 2020 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

@jtojnar jtojnar jtojnar approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Terminator is not rendering URLs with links
3 participants
@SFrijters @bjornfor @jtojnar