Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ldgallery: init at 2.0 #86599

Merged
merged 1 commit into from Jan 2, 2021
Merged

ldgallery: init at 2.0 #86599

merged 1 commit into from Jan 2, 2021

Conversation

pacien
Copy link
Contributor

@pacien pacien commented May 2, 2020 •
edited

Motivation for this change

This is an attempt at packaging ldgallery, a static gallery generator.

It's made out of three parts:

  • "ldgallery-viewer" which requires NodeJS to be built
  • "haskellPackages.ldgallery-compiler" which is an Haskell app
  • the "ldgallery" package that assembles the two previous ones
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pacien pacien mentioned this pull request May 2, 2020
Open
@pacien pacien mentioned this pull request May 2, 2020
Closed
@pacien pacien force-pushed the ldgallery-init branch 2 times, most recently from 6f8ee93 to 5d33216 Compare September 25, 2020 15:47
@pacien pacien changed the title [WIP] ldgallery: init at 1.0 ldgallery: init at 2.0 Sep 25, 2020
@pacien pacien marked this pull request as ready for review September 25, 2020 15:52
@cdepillabout
Copy link
Member

@pacien Sorry about basically forgetting about this. Are you still hoping to get this into nixpkgs?

I guess this is just ready for a final review and hopefully a merge-in?

thiagokokada
thiagokokada reviewed Dec 31, 2020
View reviewed changes
Copy link
Contributor

@thiagokokada thiagokokada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but build is failing (nixpkgs-review):

error: anonymous function at /home/thiagoko/.cache/nixpkgs-review/pr-86599-1/nixpkgs/pkgs/development/node-packages/node-env.nix:3:1 called without required argument 'util-linux', at /home/thiagoko/.cache/nixpkgs-review/pr-86599-1/nixpkgs/pkgs/tools/graphics/ldgallery/viewer/node-composition.nix:8:13
(use '--show-trace' to show detailed location information)
nix eval --json (import /nix/store/rlqba15z5wcnh7msqq94jddxjswk2032-nixpkgs-review-2.4.2/lib/python3.8/site-packages/nixpkgs_review/nix/evalAttrs.nix /run/user/1000/tmp6b8iseyh) failed to run, /run/user/1000/tmp6b8iseyh was stored inspection
https://github.com/NixOS/nixpkgs/pull/86599 failed to build
$ git worktree prune

pkgs/tools/graphics/ldgallery/compiler/generate.sh Outdated Show resolved Hide resolved
@pacien
Copy link
Contributor Author

pacien commented Jan 1, 2021 •
edited

@thiagokokada wrote:

Code looks good, but build is failing (nixpkgs-review):

error: anonymous function at /home/thiagoko/.cache/nixpkgs-review/pr-86599-1/nixpkgs/pkgs/development/node-packages/node-env.nix:3:1 called without required argument 'util-linux', at /home/thiagoko/.cache/nixpkgs-review/pr-86599-1/nixpkgs/pkgs/tools/graphics/ldgallery/viewer/node-composition.nix:8:13
(use '--show-trace' to show detailed location information)
nix eval --json (import /nix/store/rlqba15z5wcnh7msqq94jddxjswk2032-nixpkgs-review-2.4.2/lib/python3.8/site-packages/nixpkgs_review/nix/evalAttrs.nix /run/user/1000/tmp6b8iseyh) failed to run, /run/user/1000/tmp6b8iseyh was stored inspection
https://github.com/NixOS/nixpkgs/pull/86599 failed to build
$ git worktree prune

This seems to be due to svanderburg/node2nix#213.
I modified the generate.sh script accordingly to fix the package in the meantime.

@cdepillabout wrote:

Are you still hoping to get this into nixpkgs?
I guess this is just ready for a final review and hopefully a merge-in?

Yes, it builds and should now be ready.

@thiagokokada
Copy link
Contributor

thiagokokada commented Jan 1, 2021 •
edited

Result of nixpkgs-review pr 86599 1

2 packages built:
  • haskellPackages.ldgallery-compiler
  • ldgallery

Builds and run, but didn't test it very far.

@cdepillabout
Copy link
Member

cdepillabout commented Jan 2, 2021 •
edited

@pacien Looks good, thanks for fixing this up!

@thiagokokada Thanks for doing reviews here!

@cdepillabout cdepillabout merged commit 3080f1b into NixOS:master Jan 2, 2021
@pacien pacien mentioned this pull request Jun 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout cdepillabout left review comments

@thiagokokada thiagokokada thiagokokada approved these changes

Assignees
No one assigned
Labels
6.topic: haskell 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pacien @cdepillabout @thiagokokada